Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix :indent-style crash #9087

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

TornaxO7
Copy link
Contributor

Closes #9082

@TornaxO7
Copy link
Contributor Author

I couldn't think of a better solution for the indent-auto-detecting function because I agree its implementation.

@TornaxO7 TornaxO7 marked this pull request as ready for review December 15, 2023 12:36
@the-mikedavis the-mikedavis changed the title fix :indent-style crash and improve auto-indent-style-detection fix :indent-style crash Dec 15, 2023
@the-mikedavis the-mikedavis added C-bug Category: This is a bug S-waiting-on-review Status: Awaiting review from a maintainer. A-command Area: Commands labels Dec 15, 2023
@pascalkuthe
Copy link
Member

pascalkuthe commented Dec 15, 2023

I do still want to investigate the heuristic. I do think it can be improved and that this case was a bug indicative of larger issues I ran into before.

@pascalkuthe
Copy link
Member

I will merge this for now but we should investigate further

@pascalkuthe pascalkuthe merged commit 914c834 into helix-editor:master Dec 15, 2023
6 checks passed
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
* removing unreachable statement in `:indent-style`

* update checks when setting indent line and update docs

* `cargo xtask docgen`
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
* removing unreachable statement in `:indent-style`

* update checks when setting indent line and update docs

* `cargo xtask docgen`
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
* removing unreachable statement in `:indent-style`

* update checks when setting indent line and update docs

* `cargo xtask docgen`
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
* removing unreachable statement in `:indent-style`

* update checks when setting indent line and update docs

* `cargo xtask docgen`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-command Area: Commands C-bug Category: This is a bug S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown file indent-style detection and crash
3 participants